Add USD values to all remaining PLOT amounts on profile#697
Add USD values to all remaining PLOT amounts on profile#697realproject7 merged 4 commits intomainfrom
Conversation
- Writer Stats: donations + claimable show USD - StoryRow: token price shows USD - ProfileDonationHistory: donation rows show USD - StoryDonationCount: inline donation stat shows USD - Portfolio holdings: price + entry price show USD - Donations Received/Given: all amounts show USD - Activity tab: trade + donation entries show USD - ProfileHeader: royalties show USD Fixes #694 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE — Comprehensive coverage of all acceptance criteria:
Stories tab:
- Writer Stats: Donations + Claimable now show USD ✅
- StoryDonationCount: inline donation stat shows USD ✅
- ProfileDonationHistory: donation rows show USD ✅
Portfolio tab:
- Donations Received summary shows USD ✅
- Donations Given header + individual rows show USD ✅
- Holdings: price + entry price show USD ✅
Activity tab:
- Trade + donation entries show USD via
reserveAmountfield on FeedEntry ✅
Header:
- Royalties now show USD ✅
Good approach on the Activity tab — adding reserveAmount to FeedEntry rather than parsing formatted strings. Independent usePlotUsdPrice() calls in sub-components are fine since react-query deduplicates.
LGTM.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The PR covers the new USD labels in page.tsx, but it does not actually satisfy #694's "no PLOT amount anywhere on the profile page lacks a USD equivalent" acceptance criterion.
Findings
- [medium]
ClaimRoyaltiesis rendered from the profile page, but it still shows raw PLOT amounts with no USD equivalent in multiple own-profile states.- File:
src/components/ClaimRoyalties.tsx:142 - File:
src/components/ClaimRoyalties.tsx:158 - File:
src/components/ClaimRoyalties.tsx:190 - Suggestion: reuse the already-passed
plotUsdprop to append the same muted(≈ $X.XX)text anywhere this component renders a PLOT amount.
- File:
Decision
Requesting changes because own-profile views with claimed royalties still violate the issue's "USD everywhere" requirement.
- Tooltip unclaimed amount shows USD - Cumulative claimed total shows USD - Post-claim confirmation shows USD Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The follow-up commit fixed the three positive-value locations I flagged, but ClaimRoyalties still leaves a common zero-value state without a USD equivalent.
Findings
- [medium]
ClaimRoyaltiesstill renders bare0 PLOTwhenunclaimed === 0, because the USD suffix is gated onunclaimed > 0.- File:
src/components/ClaimRoyalties.tsx:149 - File:
src/components/ClaimRoyalties.tsx:151 - Suggestion: if this component is meant to satisfy #694's "every PLOT value" requirement, append USD for zero amounts too, or stop rendering the numeric PLOT amount in zero states.
- File:
Decision
Requesting changes because own-profile storylines with zero unclaimed royalties still show a PLOT value on the profile page without a USD equivalent.
project7-interns
left a comment
There was a problem hiding this comment.
Re-reviewed after T3's fix. All 3 ClaimRoyalties locations now show USD values:
- Tooltip unclaimed amount (line 142) ✅
- Cumulative claimed (line 158) ✅
- Post-claim confirmation (line 190) ✅
plotUsd prop was already threaded into the component. Fix is correct. APPROVE.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The latest commit fixes the visible zero-unclaimed line in ClaimRoyalties, but one zero-value PLOT display still lacks USD in the tooltip copy.
Findings
- [medium] The tooltip text still omits USD when
unclaimed === 0, because that inline suffix is still gated onunclaimed > 0.- File:
src/components/ClaimRoyalties.tsx:142 - Suggestion: remove the same
unclaimed > 0guard from the tooltip string, or stop rendering the numericPLOTamount there for zero states.
- File:
Decision
Requesting changes because #694 says every PLOT value on the profile page should have a USD equivalent, and the tooltip still shows a bare zero-value PLOT amount.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commits now satisfy #694. The remaining zero-value ClaimRoyalties cases I flagged are covered, including the tooltip and the visible zero-unclaimed state.
Findings
- None.
Decision
Approved because every PLOT amount I previously flagged on the profile page now has a USD equivalent, and the implementation remains narrowly scoped to the profile display paths.
Summary
(≈ $X.XX)usePlotUsdPrice()hook — no new API callsreserveAmountfield to Activity tab'sFeedEntryfor USD conversion in feed rowsLocations updated
Self-verification
npm run buildpassesFixes #694
🤖 Generated with Claude Code